Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dynamic-fields): [Worldpay] update dynamic fields for payments #7002

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Jan 7, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds below dynamic required fields for processing Worldpay payments -

  • address.line1
  • address.city
  • address.country

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

The txn will fail in case a few details are missing from address while processing a payment. To fix this, required fields are updated in RequiredFields struct which is requested by SDK at runtime for dynamically rendering the inputs for the required fields.

How did you test it?

Tested by rendering a payment link locally.

Screenshot 2025-01-07 at 4 22 32 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m self-assigned this Jan 7, 2025
@kashif-m kashif-m requested a review from a team as a code owner January 7, 2025 10:52
Copy link

semanticdiff-com bot commented Jan 7, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/configs/defaults/payment_connector_required_fields.rs  31% smaller

@kashif-m kashif-m linked an issue Jan 7, 2025 that may be closed by this pull request
2 tasks
@kashif-m kashif-m added the A-connector-compatibility Area: Connector compatibility label Jan 7, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit b46a921 Jan 8, 2025
17 of 19 checks passed
@likhinbopanna likhinbopanna deleted the 6316-worldpay-dynamic-fields branch January 8, 2025 08:15
pixincreate added a commit that referenced this pull request Jan 9, 2025
…d-memory-cache

* 'main' of github.com:juspay/hyperswitch:
  chore(version): 2025.01.09.0
  fix(cypress): backup and restore sessions when using user apis (#6978)
  feat(users): handle edge features for users in tenancy (#6990)
  chore(dynamic-fields): [Worldpay] update dynamic fields for payments (#7002)
  chore(version): 2025.01.08.0
  fix: consider status of payment method before filtering wallets in list pm (#7004)
  feat(core): add columns unified error code and error message in refund table (#6933)
  feat(connector): [Fiuu] Consume transaction id for error cases for Fiuu (#6998)
  docs(cypress): update cypress documentation (#6956)
pixincreate added a commit to Ankesh2004/hyperswitch that referenced this pull request Jan 9, 2025
…r-verifyurl-in-redirection-handler

* 'main' of github.com:juspay/hyperswitch: (30 commits)
  test(cypress): add test for In Memory Cache (juspay#6961)
  chore(version): 2025.01.09.1
  fix(dummyconnector): add tenant id in dummyconnector requests (juspay#7008)
  chore(version): 2025.01.09.0
  fix(cypress): backup and restore sessions when using user apis (juspay#6978)
  feat(users): handle edge features for users in tenancy (juspay#6990)
  chore(dynamic-fields): [Worldpay] update dynamic fields for payments (juspay#7002)
  chore(version): 2025.01.08.0
  fix: consider status of payment method before filtering wallets in list pm (juspay#7004)
  feat(core): add columns unified error code and error message in refund table (juspay#6933)
  feat(connector): [Fiuu] Consume transaction id for error cases for Fiuu (juspay#6998)
  docs(cypress): update cypress documentation (juspay#6956)
  chore(version): 2025.01.07.0
  chore(keymanager): add tenant-id to keymanager requests (juspay#6968)
  ci(cypress): Add Session Token Testcases (juspay#6683)
  Ci(Cypress): Add PML test and Dynamic Fields Test for Novalnet (juspay#6544)
  chore(version): 2025.01.06.0
  ci(cypress): fix adyen sofort in cypress (juspay#6984)
  chore: add migrations for Currency type in DB (juspay#6980)
  chore(version): 2025.01.03.0
  ...
pixincreate added a commit that referenced this pull request Jan 9, 2025
…d-memory-cache

* 'main' of github.com:juspay/hyperswitch:
  test(cypress): add test for In Memory Cache (#6961)
  chore(version): 2025.01.09.1
  fix(dummyconnector): add tenant id in dummyconnector requests (#7008)
  chore(version): 2025.01.09.0
  fix(cypress): backup and restore sessions when using user apis (#6978)
  feat(users): handle edge features for users in tenancy (#6990)
  chore(dynamic-fields): [Worldpay] update dynamic fields for payments (#7002)
  chore(version): 2025.01.08.0
  fix: consider status of payment method before filtering wallets in list pm (#7004)
  feat(core): add columns unified error code and error message in refund table (#6933)
  feat(connector): [Fiuu] Consume transaction id for error cases for Fiuu (#6998)
  docs(cypress): update cypress documentation (#6956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-compatibility Area: Connector compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Worldpay payments integration
4 participants