feat: make storage layer pluginable and add cassandra support #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/storage/adapter/cassandra.rs
Outdated
| type AdapterType = Cassandra; | ||
|
|
||
| async fn from_config(_config: &Config) -> Self { | ||
| unimplemented!("Not implemented Yet") |
There was a problem hiding this comment.
Can we include lints in Cargo.toml?
References:
- Lints to include: https://github.com/juspay/hyperswitch/blob/0dba763c3a1c69fa282ffa644a12d37dc14d8f7b/Cargo.toml#L12-L38
- Since we don't have a workspace here, refer to how we include lints in card vault: https://github.com/juspay/hyperswitch-card-vault/blob/db89f3be1e09dbf80a29828da20f5367c6d7fb1b/Cargo.toml#L106-L123
There was a problem hiding this comment.
Why is the CI check not failing, then?
There was a problem hiding this comment.
It looks like this being annotated with #[async_trait::async_trait] is causing clippy to not throw any warnings.
src/app.rs
Outdated
|
|
||
| #[cfg(feature = "cassandra")] | ||
| type StorageState = DbState<adapter::Cassandra>; | ||
| type StorageState = DbState<Pool<AsyncPgConnection>, adapter::Cassandra>; |
There was a problem hiding this comment.
This shouldn't be included ideally, for Cassandra?
There was a problem hiding this comment.
This is just a placeholder will add a comment
src/storage.rs
Outdated
| impl<C, T: DbAdapterType> DbState<C, T> | ||
| where | ||
| Self: DbAdapter, | ||
| { | ||
| /// # Panics | ||
| /// | ||
| /// Panics if unable to connect to Database | ||
| #[allow(clippy::expect_used)] |
There was a problem hiding this comment.
Can we also remove the allow annotation here?
dracarys18
force-pushed
the
plugin_storage
branch
from
94468ae to
556e21d
Compare
dracarys18
changed the title
…ce into plugin_storage
akshay-97
approved these changes
Dec 23, 2024
jarnura
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make the storage layer plugin-able in the intention of adding another storage layer should be simple enough