-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add ci to check the compilation,formatting and clippy #28
Conversation
Thanks for the PR @notnick2! There are few changes that needs to be done before we merge this, Please do check and let me know if you have any doubts |
@dracarys18 I have made the required changes. Please review it and mention any changes if required |
@dracarys18 for a PR to get accepted for hacktoberfest maintainers need to add hacktoberfest-accepted label to the PR It would be extremely helpful if you add |
Sure @notnick2 I will add after the PR is merged. Once small change though can you fix it? |
name: CI
on:
push:
branches:
- main
pull_request: will this resolve the issue, this changes will test push only to the main branch and all the pull request from any branch |
Yes this should work |
@dracarys18 made the required changes everything should work well now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, looks good to me!
@SanchithHegde I have made the required changes. Please review it and mention any changes if required |
@SanchithHegde removed needs: build for the formatting job. Please review this and mention if any changes are required. |
@dracarys18 your approval has been dismissed as stale review and I don't know why, can you please review it one last time and approve the changes. |
Thanks for the contribution @notnick2 |
Description
Added a CI workflow configuration in
.github/workflows/ci.yml
.This pull request adds a Continuous Integration (CI) workflow for the project, which includes the following checks:
cargo fmt
.PS I'm new to open source contributions and I appreciate any guidance or feedback on my contributions. Thank you!