Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add ci to check the compilation,formatting and clippy #28

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

notnick2
Copy link
Contributor

@notnick2 notnick2 commented Oct 9, 2024

Description

Added a CI workflow configuration in .github/workflows/ci.yml.

This pull request adds a Continuous Integration (CI) workflow for the project, which includes the following checks:

  1. Code Formatting: Ensures that the code adheres to the project's formatting guidelines using cargo fmt.
  2. Compilation: Checks that the project compiles successfully without errors.
  3. Clippy Linting: Runs Clippy to catch common mistakes and improve the quality of the code.

PS I'm new to open source contributions and I appreciate any guidance or feedback on my contributions. Thank you!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dracarys18 dracarys18 changed the title Added a CI to check formatting, compilation and clippy feat(ci): add ci to check the compilation,formatting and clippy Oct 9, 2024
@dracarys18
Copy link
Member

Thanks for the PR @notnick2! There are few changes that needs to be done before we merge this, Please do check and let me know if you have any doubts

@dracarys18 dracarys18 linked an issue Oct 9, 2024 that may be closed by this pull request
@notnick2
Copy link
Contributor Author

notnick2 commented Oct 9, 2024

@dracarys18 I have made the required changes. Please review it and mention any changes if required

@notnick2
Copy link
Contributor Author

@dracarys18 for a PR to get accepted for hacktoberfest maintainers need to add hacktoberfest-accepted label to the PR

It would be extremely helpful if you add hacktoberfest-accepted label to this PR for my PR to get accepted

image

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dracarys18
Copy link
Member

Sure @notnick2 I will add after the PR is merged. Once small change though can you fix it?

@notnick2
Copy link
Contributor Author

@dracarys18

name: CI
on:
  push:
    branches:
      - main   
  pull_request:  

will this resolve the issue, this changes will test push only to the main branch and all the pull request from any branch
I'm little confused if you can help me clarify it would be helpful

@dracarys18
Copy link
Member

@dracarys18

name: CI
on:
  push:
    branches:
      - main   
  pull_request:  

will this resolve the issue, this changes will test push only to the main branch and all the pull request from any branch
I'm little confused if you can help me clarify it would be helpful

Yes this should work

@notnick2
Copy link
Contributor Author

@dracarys18 made the required changes everything should work well now!

dracarys18
dracarys18 previously approved these changes Oct 11, 2024
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@notnick2
Copy link
Contributor Author

@SanchithHegde I have made the required changes. Please review it and mention any changes if required

@notnick2
Copy link
Contributor Author

@SanchithHegde removed needs: build for the formatting job. Please review this and mention if any changes are required.

@notnick2
Copy link
Contributor Author

@dracarys18 your approval has been dismissed as stale review and I don't know why, can you please review it one last time and approve the changes.

@dracarys18
Copy link
Member

Thanks for the contribution @notnick2

@dracarys18 dracarys18 merged commit 63c6794 into juspay:main Oct 14, 2024
@notnick2 notnick2 deleted the add-ci-workflow branch October 14, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Add github CI for keymanager
3 participants