Separate profiler out of the user interface #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #45
This allows downstream to run benchmarks programatically, including via playwright if jupyterlab app is exposed.
Code changes:
IUIProfiler
was extended to offer the following methods and properties:@jupyterlab/ui-profiler:user-interface
was added which relies onIUIProfiler
provided by@jupyterlab/ui-profiler:plugin
tokens.ts
and are now exported as public API membersUIProfiler
toUIProfilerWidget
IUIProfiler
is now implemented in newUIProfiler
classIBenchmarkResultBase
,IBenchmarkData
, andtype BenchmarkResult
were merged into a single simplifiedIBenchmarkResult
IOutcome
is now stored inIBenchmarkResult
under.outcome
field rather than (confusingly).result
as before; this is a soft deprecation, result loader supports the old format for now.