Update example workflow to include comment reaction (:+1:) #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
reviewed
Sep 14, 2023
README.md
Outdated
| @@ -426,10 +426,16 @@ permissions: | |||
|
|
|||
| jobs: | |||
| update-snapshots: | |||
| if: ${{ github.event.issue.pull_request && contains(github.event.comment.body, 'update playwright snapshots') }} | |||
| if: ${{ github.event.issue.pull_request && contains(github.event.comment.body, 'please update playwright snapshots') }} | |||
There was a problem hiding this comment.
I am not sure if we should require please here (some users forger about it). I would even go as far as allowing to omit playwright or at least replacing it with generic term like "test snapshots" (as an alternative - I would keep the current option too).
krassowski
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Thank you @jtpio!
MacOS test is acting up, will need a re-run
|
The MacOS checks passed after the re-run ✔️ Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port jupyterlab/jupyterlab#15070 to the Galata update example workflow.