Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the
Application
fully composable #705base: main
Are you sure you want to change the base?
Make the
Application
fully composable #705Changes from all commits
60be174
9709c86
d722a13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to have the full picture here, and to provide more context for the future when looking back at that PR.
The main purpose for allowing an
HTMLElement
directly would be for apps reusing the Lumino plugin system to not have to depend on@lumino/widgets
to instantiate a placeholder shell widget, for example like in the following example?lumino/packages/application/tests/src/index.spec.ts
Lines 21 to 24 in 0fb17ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, although that the
ContextMenu
API is preventing to make@lumino/widgets
an optional dependency;lumino/packages/application/src/index.ts
Line 70 in 0fb17ae