Expose settings API to other handlers.

[goanpeca]

Hi @afshin, would something like this be ok so other handlers can access the settings in a friendlier fashion?

On the localization work, I use the current locale set by the user and based on that I provide the available language in original and localized form (for the current local)

Thoughts?

[afshin]

Cheers @goanpeca!

This is a good solution to how server side extensions access user settings.

[goanpeca]

Ok, let me add some tests then :-p

[afshin]

Is it possible to combine _get_settings and get_settings so that the handler uses the same exact logic? It might prevent an out of sync bug in the future.

[goanpeca]

Is it possible to combine _get_settings and get_settings so that the handler uses the same exact logic? It might prevent an out of sync bug in the future.

Yeah I think so. Will update the code.

[goanpeca]

Is it possible to combine _get_settings and get_settings so that the handler uses the same exact logic? It might prevent an out of sync bug in the future.

@afshin I did something else, get_settings is now used inside the get handler and also as the API exposed to other handlers so now the handler and the API use the same get_settings (public) method. The private _get_settings, well is private and has a different signature so no risk getting out of sync now.

Since now the get method is using the same thing as the API (public method) I think the current tests are covering the use cases.

[goanpeca]

This is faster to use than dict, so .. why not use it 🙃

[blink1073]

Published as 1.2.0, JupyterLab will need an update: https://github.com/jupyterlab/jupyterlab/blob/master/setup.py#L154