-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add store ID to page config #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@vidartf, any objections? |
The concept is good. Its probably (?) ok to put it on the application object. |
I only used it because of a stack overflow response:
I couldn't find any Tornado docs that mention this use case. Maybe @Zsailer would know? |
Like @vidartf, I think this is fine. I was trying to find a scenario like this in JupyterHub—thinking there might be some semi-persistent data case there—but was unsuccessful. Typically, all persistent data storage mechanisms are listed in "setting" of the tornado application and stored somewhere on the server, but if you don't need this data to persist after the server is stopped, this should work. The data should persist with each request... |
Released as 1.0.2. |
@blink1073 Thank you! |
No description provided.