Use json5 to load settings files. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Json5 isn't on conda-forge yet... |
|
Hrm, I was hoping to avoid re-implementing... |
|
This came up last week, where the server-side and client-side validators for the settings files gave different answers (particularly around ECMA identifiers-as-keys). |
|
It is fairly straightforward to get something on conda-forge. It doesn't have any dependencies. |
|
I'm sick today, but here are the instructions: https://conda-forge.org/#add_recipe |
|
|
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This json5 implementation seems like is works okay -- it is written by someone on the Chromium team. It has all sorts of blinking disclaimers that it is extremely slow, but I don't think we need a particularly high-performance algorithm for this use-case.