Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change periodic callback time from tuple to int (#376 #376

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

rmoe
Copy link
Contributor

@rmoe rmoe commented Feb 23, 2023

Closes: #375

@welcome
Copy link

welcome bot commented Feb 23, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Base: 80.86% // Head: 80.87% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (aee7294) compared to base (eb37a21).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   80.86%   80.87%   +0.01%     
==========================================
  Files          22       22              
  Lines        1766     1767       +1     
  Branches      333      333              
==========================================
+ Hits         1428     1429       +1     
  Misses        235      235              
  Partials      103      103              
Impacted Files Coverage Δ
jupyterlab_server/handlers.py 78.23% <50.00%> (ø)
jupyterlab_server/listings_handler.py 83.33% <100.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rmoe rmoe force-pushed the 375-callback-time-type-error branch from 9b61a0d to 4d12c3d Compare February 27, 2023 17:50
@rmoe rmoe force-pushed the 375-callback-time-type-error branch from 4d12c3d to aee7294 Compare February 27, 2023 17:50
@rmoe
Copy link
Contributor Author

rmoe commented Feb 27, 2023

@blink1073 is there something else I need to do to get these tests to pass? I can run hatch run test:nowarn locally and it passes. Are these tests expected to fail here?

@blink1073 blink1073 added the bug label Feb 28, 2023
@blink1073
Copy link
Contributor

Thanks @rmoe! The pre-release failure is unrelated, the openapi libraries keep changing APIs on us.

@blink1073 blink1073 changed the title Change periodic callback time from tuple to int Change periodic callback time from tuple to int (#376 Feb 28, 2023
@blink1073 blink1073 merged commit 7013e0a into jupyterlab:main Feb 28, 2023
@welcome
Copy link

welcome bot commented Feb 28, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jupyterlab_server fails when allowed_extensions_uris is set
3 participants