Revert "Fix some CodeQL notices" #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcollonval
force-pushed
the
revert-371-maintenance/codeql
branch
from
444e78f
to
f435271
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+8
to
+13
| from jupyter_server.base.handlers import ( | ||
| APIHandler, | ||
| FileFindHandler, | ||
| JupyterHandler, | ||
| json_errors, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import
Comment on lines
+14
to
+19
| from jupyter_server.extension.serverextension import ( | ||
| GREEN_ENABLED, | ||
| GREEN_OK, | ||
| RED_DISABLED, | ||
| RED_X, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import
| """Server api.""" | ||
| # FIXME TODO Deprecated remove this file for the next major version | ||
| # Downstream package must import those items from `jupyter_server` directly | ||
| from jupyter_server import _tz as tz |
Check notice
Code scanning / CodeQL
Unused import
| RED_DISABLED, | ||
| RED_X, | ||
| ) | ||
| from jupyter_server.serverapp import ServerApp, aliases, flags |
Check notice
Code scanning / CodeQL
Unused import
| RED_X, | ||
| ) | ||
| from jupyter_server.serverapp import ServerApp, aliases, flags | ||
| from jupyter_server.utils import url_escape, url_path_join |
Check notice
Code scanning / CodeQL
Unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #371 partly to restore
server.pythat may be consumed by downstream package