Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper setup for the fallback logger #269

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Conversation

rvalieris
Copy link
Contributor

fix for #268

the previous code was setting the log level of the root logger, and creating a fallback "jupyterlab" logger that inherits from root. also this was being set outside of any function/method so just by importing the file the log level changed.

since the root logger is not actually used, its better to set the level directly on the fallback logger and only if the passed on logger is not available which shouldn't happen anyway.

@welcome
Copy link

welcome bot commented Apr 27, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #269 (d785432) into main (93703e2) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   65.37%   65.18%   -0.19%     
==========================================
  Files          22       22              
  Lines        1730     1735       +5     
  Branches      295      296       +1     
==========================================
  Hits         1131     1131              
- Misses        515      520       +5     
  Partials       84       84              
Impacted Files Coverage Δ
jupyterlab_server/process.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93703e2...d785432. Read the comment docs.

@blink1073 blink1073 added the bug label Apr 27, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 02dc601 into jupyterlab:main Apr 27, 2022
@welcome
Copy link

welcome bot commented Apr 27, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@rvalieris rvalieris deleted the patch branch April 27, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants