proper setup for the fallback logger #269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #268
the previous code was setting the log level of the root logger, and creating a fallback "jupyterlab" logger that inherits from root. also this was being set outside of any function/method so just by importing the file the log level changed.
since the root logger is not actually used, its better to set the level directly on the fallback logger and only if the passed on logger is not available which shouldn't happen anyway.