Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve paths in tests #245

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Resolve paths in tests #245

merged 1 commit into from
Mar 17, 2022

Conversation

@blink1073 blink1073 added the bug label Mar 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #245 (3a96127) into main (2788986) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   69.34%   69.34%           
=======================================
  Files          20       20           
  Lines        1631     1631           
=======================================
  Hits         1131     1131           
  Misses        500      500           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2788986...3a96127. Read the comment docs.

@blink1073 blink1073 merged commit 271f616 into jupyterlab:main Mar 17, 2022
@blink1073 blink1073 deleted the resolve-path branch March 17, 2022 11:42
@bollwyvl
Copy link
Contributor

Cool, thanks. It does still seem a bit odd that the tests are separated out, but not the test_data.

Of additional note: we're also having to do special stuff to handle the the yml file.

I wonder if the yml path should be hoisted to someplace in the programmatic API... not the parsed data, though, I guess, unless we pre-generated is JSON... yaml parsing in the hot path of a request (or even a server startup) seems to be an anti-feature.

@blink1073
Copy link
Contributor Author

It does still seem a bit odd that the tests are separated out, but not the test_data.

We needed test_data that is used by the pytest_plugin (settings, workspace files, etc.).

In general including tests in your package is not supported by pytest, and we had had to strip out the translation tests due to path length restrictions on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants