-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Tests in Sdist But Not Wheel #239
Conversation
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage ? 68.47%
=======================================
Files ? 19
Lines ? 1567
Branches ? 0
=======================================
Hits ? 1073
Misses ? 494
Partials ? 0 Continue to review full report at Codecov.
|
exclude = ['docs*'] | ||
exclude = | ||
docs* | ||
tests* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blink1073 I think this is responsible for this error:
ImportError: Error importing plugin "jupyterlab_server.pytest_plugin": No module named 'jupyterlab_server.pytest_plugin'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll make a fix
Looks like this makes the JupyterLab tests fail with the latest https://github.com/jupyterlab/jupyterlab/runs/5583340091?check_suite_focus=true
|
Ah I see there is discussion about this starting from this comment: #243 (comment) |
I inlined |
This allows us to test on
conda-forge
with all of the tests, and use the layout recommended bypytest
.I'll follow this up with some CI cleanup.