Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: clarify build system version #222

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

adamjstewart
Copy link
Contributor

@welcome
Copy link

welcome bot commented Dec 9, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #222 (3f8aaf6) into master (d577120) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   76.96%   76.96%           
=======================================
  Files          28       28           
  Lines        2071     2071           
=======================================
  Hits         1594     1594           
  Misses        477      477           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d577120...3f8aaf6. Read the comment docs.

pyproject.toml Outdated Show resolved Hide resolved
@blink1073
Copy link
Contributor

Thanks! I updated it to include 1.x support.

@blink1073 blink1073 merged commit ea75fc0 into jupyterlab:master Dec 13, 2021
@welcome
Copy link

welcome bot commented Dec 13, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@adamjstewart
Copy link
Contributor Author

Was dropping 0.9 support intentional?

@blink1073
Copy link
Contributor

I was looking at jupyter/jupyter-packaging#120 when I made the change. It doesn't matter very much, since the library is only used in the isolated build environ.

@adamjstewart adamjstewart deleted the fixes/pyproject.toml branch December 13, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants