Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add page_config_hook #220

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Nov 18, 2021

  • move page_config to get_page_config() method, so it can be overridden (used in NotFoundHandler)
  • support settings["page_config_hook"] for customizing page config on a per-request basis. Hook shoud look like:
def page_config_hook(handler: RequestHandler, page_config: Dict) -> Dict:
    ...

closes #219

- move page_config to `get_page_config()` method, so it can be overridden (used in NotFoundHandler)
- support `settings["page_config_hook"]` for customizing page config on a per-request basis
@welcome
Copy link

welcome bot commented Nov 18, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #220 (17d0810) into master (1a2fdac) will increase coverage by 0.04%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   76.96%   77.00%   +0.04%     
==========================================
  Files          28       28              
  Lines        2071     2079       +8     
==========================================
+ Hits         1594     1601       +7     
- Misses        477      478       +1     
Impacted Files Coverage Δ
jupyterlab_server/handlers.py 87.80% <91.30%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a2fdac...17d0810. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 5f763c6 into jupyterlab:master Dec 13, 2021
@welcome
Copy link

welcome bot commented Dec 13, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject page config on a per-request basis
3 participants