-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add page_config_hook #220
add page_config_hook #220
Conversation
- move page_config to `get_page_config()` method, so it can be overridden (used in NotFoundHandler) - support `settings["page_config_hook"]` for customizing page config on a per-request basis
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 76.96% 77.00% +0.04%
==========================================
Files 28 28
Lines 2071 2079 +8
==========================================
+ Hits 1594 1601 +7
- Misses 477 478 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
get_page_config()
method, so it can be overridden (used in NotFoundHandler)settings["page_config_hook"]
for customizing page config on a per-request basis. Hook shoud look like:closes #219