Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to context-less translation on Python 3.7 #213

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

krassowski
Copy link
Member

Fallback to context-less translation on Python 3.7 and fix some typing issues.

Fixes jupyterlab/jupyterlab#11148, based on napari/napari#2305 (added @goanpeca as a co-author).

and fix some typing issues.

Co-authored-by: goanpeca <goanpeca@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #213 (3bc9716) into master (3c905c1) will decrease coverage by 0.20%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   77.16%   76.96%   -0.21%     
==========================================
  Files          28       28              
  Lines        2063     2071       +8     
==========================================
+ Hits         1592     1594       +2     
- Misses        471      477       +6     
Impacted Files Coverage Δ
jupyterlab_server/translation_utils.py 74.03% <38.46%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c905c1...3bc9716. Read the comment docs.

Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @krassowski

LGTM!

@blink1073 blink1073 added the bug label Sep 25, 2021
@blink1073 blink1073 merged commit 27cead5 into jupyterlab:master Sep 25, 2021
@blink1073
Copy link
Contributor

Thanks! Starting a release now

@krassowski krassowski deleted the fix-translation-python-3.7 branch September 25, 2021 15:56
@krassowski
Copy link
Member Author

Thanks for a quick release! I just confirmed that it works well with the latest release using a new gist with jupyterlab-server==2.8.2 pin (https://gist.github.com/krassowski/cef3614c3eae6d17f078fe15d88372c3).

@blink1073
Copy link
Contributor

Great, thanks for verifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language packs break JupyterLab on Python 3.7 completely
4 participants