Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reset user settings if validation failed #199

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fix reset user settings if validation failed #199

merged 1 commit into from
Aug 17, 2021

Conversation

fcollonval
Copy link
Member

If user settings are not valid, raw is set to an empty object but settings is kept unchanged.

This makes settings equivalent to raw in case of validation error.

@blink1073
Copy link
Contributor

I was going to cut a release with #198, should I hold off a bit for this?

@fcollonval fcollonval marked this pull request as ready for review August 17, 2021 13:37
@fcollonval
Copy link
Member Author

I was going to cut a release with #198, should I hold off a bit for this?

It is good to go on my side.

@blink1073 blink1073 added the bug label Aug 17, 2021
blink1073
blink1073 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 4c5f9c8 into jupyterlab:master Aug 17, 2021
@fcollonval fcollonval deleted the fix/reset-settings branch August 17, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @blink1073