Update settings handler to parse complex URL paths. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afshin
force-pushed
the
settings-url
branch
from
8f45c6e
to
2002d50
Compare
blink1073
reviewed
Sep 14, 2017
| except Exception as e: | ||
| path = os.path.join(root_dir, section_name + ".json") | ||
|
|
||
| if make_dirs and parent_dir and not os.path.exists(parent_dir): |
There was a problem hiding this comment.
parent_dir would only be defined if there was a : in the section name (need to pre-define it outside of the try block).
afshin
force-pushed
the
settings-url
branch
from
575d725
to
1aab944
Compare
afshin
force-pushed
the
settings-url
branch
from
93124e6
to
229691f
Compare
|
Verified against jupyterlab/jupyterlab#2936 current master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports making API requests to the settings handler in with the new ID schema from jupyterlab/jupyterlab#2936
(This is a backward compatible API change.)