Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to entrypoints package #187

Merged
merged 4 commits into from
Aug 10, 2021

Conversation

fcollonval
Copy link
Member

Use entrypoints package to list translation entry points

Advantages:

  • It is already a dependency (from the notebook server)
  • it is more efficient than pkgresources
  • it lists the entry points from the current sys.path => no need to run the listing in a subprocess

@welcome
Copy link

welcome bot commented Jun 15, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval fcollonval marked this pull request as draft June 15, 2021 10:34
@fcollonval fcollonval self-assigned this Jun 15, 2021
@fcollonval fcollonval marked this pull request as ready for review June 15, 2021 11:30
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bollwyvl
Copy link
Contributor

bollwyvl commented Aug 2, 2021

Hooray not relying on undeclared runtime setuptools dependency!

I would recommend adding entrypoints as an explicit dependency in setup.cfg or .py (wherever), as notebook would, along with nbclassic, be dropped in the already-started 4.0.0 line of lab. Though nbconvert will likely continue to use it, most likely, where it's been pinned to entrypoints >=0.2.2).

@fcollonval
Copy link
Member Author

Thanks for the suggestion @bollwyvl
i updated the PR.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #187 (cc92230) into master (6ecc630) will decrease coverage by 0.58%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   78.55%   77.97%   -0.59%     
==========================================
  Files          27       27              
  Lines        1996     1993       -3     
==========================================
- Hits         1568     1554      -14     
- Misses        428      439      +11     
Impacted Files Coverage Δ
jupyterlab_server/translation_utils.py 82.41% <92.30%> (-4.80%) ⬇️
jupyterlab_server/tests/test_translation_api.py 98.50% <100.00%> (-0.13%) ⬇️
jupyterlab_server/handlers.py 87.82% <0.00%> (-1.45%) ⬇️
jupyterlab_server/tests/test_settings_api.py 100.00% <0.00%> (ø)
jupyterlab_server/settings_handler.py 85.45% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ecc630...cc92230. Read the comment docs.

@fcollonval fcollonval merged commit 919186b into jupyterlab:master Aug 10, 2021
@welcome
Copy link

welcome bot commented Aug 10, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval fcollonval deleted the ft/entrypoints branch August 10, 2021 06:28
@blink1073 blink1073 modified the milestones: 2.6, 2.7 Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants