Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LabConfig configurable and add config API docs #172

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

afshin
Copy link
Member

@afshin afshin commented Mar 31, 2021

Continuation of #169

@codecov-io
Copy link

codecov-io commented Mar 31, 2021

Codecov Report

Merging #172 (846977c) into master (8d127b2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   74.70%   74.70%           
=======================================
  Files          21       21           
  Lines        1668     1668           
=======================================
  Hits         1246     1246           
  Misses        422      422           
Impacted Files Coverage Δ
jupyterlab_server/config.py 62.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d127b2...846977c. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 2.5 milestone Mar 31, 2021
@blink1073 blink1073 merged commit e72a11a into jupyterlab:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants