Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mathjax_url properly #150

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Handle mathjax_url properly #150

merged 1 commit into from
Jan 12, 2021

Conversation

afshin
Copy link
Member

@afshin afshin commented Jan 12, 2021

Fixes jupyterlab/jupyterlab#9605. The static/components url from the notebook server's mathjax_url config was getting prefixed with /lab/tree when we had a document open.

@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #150 (be0c253) into master (192c753) will decrease coverage by 0.05%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   74.92%   74.86%   -0.06%     
==========================================
  Files          21       21              
  Lines        1675     1679       +4     
==========================================
+ Hits         1255     1257       +2     
- Misses        420      422       +2     
Impacted Files Coverage Δ
jupyterlab_server/handlers.py 88.07% <60.00%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192c753...be0c253. Read the comment docs.

@blink1073 blink1073 merged commit 1501e03 into jupyterlab:master Jan 12, 2021
@blink1073
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JupyterHub, JupyterLab 3 and MarkDown-LaTeX
3 participants