Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move open_browser to ProcessApp class #149

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

jasongrout
Copy link
Contributor

This follows on the changes in ExtensionApp to move open_browser to the top-level config.

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #149 (d6c916f) into master (1f3113d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files          21       21           
  Lines        1675     1675           
=======================================
  Hits         1255     1255           
  Misses        420      420           
Impacted Files Coverage Δ
jupyterlab_server/process_app.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3113d...d6c916f. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit f35feff into jupyterlab:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants