Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up handling of config #123

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Conversation

blink1073
Copy link
Contributor

Companion to jupyterlab/jupyterlab#8950.

Moves handling of page_config here completely so it is dynamic.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #123 into master will decrease coverage by 1.21%.
The diff coverage is 25.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   60.50%   59.28%   -1.22%     
==========================================
  Files          19       20       +1     
  Lines        1504     1572      +68     
==========================================
+ Hits          910      932      +22     
- Misses        594      640      +46     
Impacted Files Coverage Δ
jupyterlab_server/config.py 24.61% <24.61%> (ø)
jupyterlab_server/handlers.py 69.38% <50.00%> (+15.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850305c...1842869. Read the comment docs.

@bollwyvl
Copy link
Contributor

bollwyvl commented Sep 3, 2020 via email

@blink1073
Copy link
Contributor Author

By dynamic, does this mean config set after starting the server would
update the defaults (with a page reload, presumably)?

Yup!

jupyterlab_server/config.py Outdated Show resolved Hide resolved
@bollwyvl
Copy link
Contributor

bollwyvl commented Sep 3, 2020 via email

@blink1073 blink1073 merged commit 8a0f9ce into jupyterlab:master Sep 3, 2020
@blink1073
Copy link
Contributor Author

Released as jupyterlab_server-2.0.0b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants