Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spurious logging issue #115

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Aug 11, 2020

This fixes the issue we've been seeing in JupyterLab with spurious logging.

See @ellisonbg's image originally posted in jupyter-server/jupyter_server#272.

image

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Zsailer
Copy link
Member Author

Zsailer commented Aug 11, 2020

Oops, fixing the tests now. I ran them locally on the wrong branch. sorry for the spam here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #115 into master will decrease coverage by 0.17%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   60.63%   60.46%   -0.18%     
==========================================
  Files          19       19              
  Lines        1504     1505       +1     
==========================================
- Hits          912      910       -2     
- Misses        592      595       +3     
Impacted Files Coverage Δ
jupyterlab_server/settings_handler.py 73.93% <85.71%> (-1.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d311986...f6cbcbf. Read the comment docs.

@Zsailer
Copy link
Member Author

Zsailer commented Aug 11, 2020

Ok, fixed!

@blink1073
Copy link
Contributor

Thanks!

@blink1073 blink1073 merged commit edf4a17 into jupyterlab:master Aug 11, 2020
@echarles
Copy link
Member

Thx @Zsailer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants