Changes needed for improved single document mode #101
Conversation
| @@ -24,6 +24,8 @@ | |||
| # ----------------------------------------------------------------------------- | |||
|
|
|||
|
|
|||
| MASTER_URL_PATTERN = '/(?P<mode>lab|doc)(?P<workspace>/workspaces/[a-zA-Z0-9\-\_]+)?(?P<tree>/tree/.*)?' | |||
There was a problem hiding this comment.
We had intentionally made lab in the url configurable in case folks have a different name for their application.
There was a problem hiding this comment.
I think we should be okay with deployers/admins owning the server, port, and base_url, and deciding that all the paths that get routed by the application server after base_url belong to us, but I did wonder if we should make this be a major version bump because even if the programmatic API is backward-compatible, URL decisions are also API from my point of view.
There was a problem hiding this comment.
With this change the /lab portion formally becomes part of our API, and this is backwards incompatible. We definitely need a major release for this. Agree with what @afshin is saying here that the server, port and base_url are the configurable portion.
|
Onward! |
|
I'll cut a 2.x alpha for this |
The PR contains the changes needed for about to the PR'd work on JupyterLab to improve the single document mode. Here is a summary of the changes to
jupyter_server:'/(?P<mode>lab|doc)(?P<workspace>/workspaces/[a-zA-Z0-9\-\_]+)?(?P<tree>/tree/.*)?'workspaces_urlandtree_urlconfig and page config no longer make sense and have been removed.workspace,mode, andtreePathpage config values that are populated by matching the regular expression. Thus, different frontend extensions no longer need to manage their own complex regexp matching to find this information.