-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add CI with github #100
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Linux tests | ||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
|
||
pull_request: | ||
branches: | ||
- "*" | ||
|
||
jobs: | ||
linux: | ||
name: Linux py${{ matrix.PYTHON_VERSION }} tests | ||
runs-on: ubuntu-latest | ||
env: | ||
CI: True | ||
PYTHON_VERSION: ${{ matrix.PYTHON_VERSION }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
PYTHON_VERSION: ['3.5', '3.6', '3.8'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like they've already got 3.9: probably better to know sooner! Heck I'd throw at least an pypy in there, too! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, will add it! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. at which point, is 3.6 even going to tell you much more than 3.5 until EOL in september? |
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
- name: Cache pip | ||
uses: actions/cache@v1 | ||
with: | ||
path: ~/.cache/pip | ||
key: ${{ runner.os }}-py-${{ matrix.PYTHON_VERSION }}-pip-${{ hashFiles('**/setup.py') }} | ||
- name: Setup python | ||
uses: actions/setup-python@v1 | ||
with: | ||
python-version: ${{ matrix.PYTHON_VERSION }} | ||
- name: Install python dependencies | ||
run: | | ||
pip install setuptools pip --upgrade | ||
pip install -v -e ".[test]" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems fine for now... though while running through it, I was a little surprised that the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤷 |
||
- name: Show python environment | ||
run: | | ||
python --version | ||
python -m pip list | ||
- name: Run python tests | ||
run: | | ||
pytest . --tb=long -svv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
baby steps, I know, but windows (and to a lesser extent, osx) is where the real problems usually occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSX build machines are "expensive" So maybe on OSX we should only run oldest and newest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too true, everything has a cost! i think as long as there is some coverage on all the platforms, it's solid. another thing i've done before, when the wall-clock time isn't as important as the overall resource footprint, is do strongest and weakest indicator builds by themselves (in this case, I guess that would be windows 3.5 and and linux 3.8?) and then open up the matrix, but still set a max concurrency.