Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code output font size to be affected by content-font-size1 #12537

Closed
wants to merge 3 commits into from

Conversation

galathinius
Copy link
Contributor

References

Fixes #12178

Code changes

Add the jp-RenderedHTMLCommon CSS class (which gets the font size from content-font-size1) to RenderedText

User-facing changes

Before:
image

After:
image

Backwards-incompatible changes

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@galathinius galathinius marked this pull request as ready for review May 27, 2022 21:28
@Zsailer
Copy link
Member

Zsailer commented Jul 16, 2022

The test failures in the visual regression tests seem relevant here. We likely need to update the tests, and likely add new tests.

@jtpio jtpio added the bug label Jul 18, 2022
@krassowski
Copy link
Member

Thank you for the PR @galathinius I will update your branch with the main branch and update snapshots.

I am not certain if we should proceed the way proposed. As I understand, this PR changes the default font size from --jp-code-font-size to --jp-code-font-size1. By some opinionated users, this might be considered a regression. A safer approach to solve #12178 could could be allowing to customise --jp-code-font-size in addition to --jp-code-font-size1. I will also tag this as needs review to get a second opinion.

@krassowski
Copy link
Member

bot please update galata snapshots

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated snapshots show that on top of changing the font size, addition of the proposed class would also break the background for exceptions:

Screenshot from 2022-08-11 20-46-06

@galathinius galathinius closed this Sep 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output font size not changing for code cells
5 participants