Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state restoration in the notebook extension #12218

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 15, 2022

References

As reported in https://github.com/jupyterlab/retrolab/issues/358, where some commands are not available in downstream applications like RetroLab since they don't include a ILayoutRestorer.

Code changes

Fix the guard checking if the restorer is available, so it only surrounds the relevant logic.

User-facing changes

Should fix some behavior in downstream applications reusing @jupyterlab/notebook-extension:tracker as is.

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added the bug label Mar 15, 2022
@jtpio jtpio added this to the 3.3.x milestone Mar 15, 2022
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jtpio

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 4123 <- [4294 - 4369 - 4413] -> 4586 2773 <- [2870 - 2903 - 2966] -> 3107
expected 4070 <- [4289 - 4336 - 4387] -> 4565 2773 <- [2863 - 2923 - 2971] -> 3109
Mean relative change 0.4% ± 0.6% -0.2% ± 0.7%
switch-from
chromium
actual 685 <- [736 - 756 - 790] -> 1055 507 <- [536 - 567 - 1014] -> 1121
expected 701 <- [740 - 757 - 790] -> 1033 496 <- [532 - 555 - 1030] -> 1262
Mean relative change -1.4% ± 3.2% -2.1% ± 9.3%
switch-to
chromium
actual 345 <- [373 - 418 - 430] -> 570 248 <- [304 - 314 - 321] -> 423
expected 344 <- [389 - 415 - 430] -> 484 269 <- [305 - 314 - 325] -> 361
Mean relative change 0.1% ± 2.3% -0.2% ± 1.7%
close
chromium
actual 668 <- [1024 - 1052 - 1073] -> 1161 495 <- [521 - 533 - 546] -> 582
expected 594 <- [1020 - 1040 - 1063] -> 1122 483 <- [521 - 532 - 541] -> 570
Mean relative change 1.6% ± 1.8% 0.5% ± 0.9%

Changes are computed with expected as reference.

@jtpio jtpio merged commit 60b79db into jupyterlab:master Mar 17, 2022
@jtpio jtpio deleted the fix-plugin-restorer branch March 17, 2022 09:17
@jtpio
Copy link
Member Author

jtpio commented Mar 17, 2022

@meeseeksdev please backport to 3.3.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Mar 17, 2022
jtpio added a commit that referenced this pull request Mar 18, 2022
…12226)

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants