Fix GitPanel unit tests #1331
Merged
Fix GitPanel unit tests #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Zsailer
force-pushed
the
fix-gitpanel-tests
branch
2 times, most recently
from
527f2af
to
0de2408
Compare
Zsailer
force-pushed
the
fix-gitpanel-tests
branch
from
0de2408
to
479d519
Compare
Zsailer
force-pushed
the
fix-gitpanel-tests
branch
from
54394c5
to
65598ca
Compare
|
We did it! The skipped tests are working and all green. Massive thank you to @jzhang20133 for debugging this with me. Let's merge and rebase #1324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1325
All credit goes to @jzhang20133!
Just opening this PR separately from #1324 to decouple the efforts of fixing unit tests vs. fixing the bug reported there.