-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite, with Welcome Page and session history #546
Conversation
I was running a version a few commits behind (b6a2795) for few days now and had overall good impressions. Some noticeable annoyances that I saw are:
Note: please feel free to move styling suggestions to follow up issues if you don't feel like tacking this, I am just trying to document these at source while we have a fresh memory of the relevant codebase. |
I guess that point (4) was already fixed by 119da42 but have not tested yet. |
Idea: one useful addition to the welcome screen could be a set of links to this repository ("Report a bug"/"Open a feature request"/"Contribute"). |
@krassowski thanks for testing. (1) happens when you start another instance of the app. I am working on a fix for that. Regarding (2), there is tooltip with the requirement to hit 'Enter' but I will apply the selected path from file dialog as you suggest. I will look into (3). (4) is fixed in the latest as you guessed. I would like to leave (5) for later. There are other scroll bars (recents list, connect to server list) which might have the same issue. |
I am not too sure about this, it would be better to keep welcome page simple and clean. We could add these links to about dialog. |
…handle invalid python path selection
@krassowski I couldn't reproduce (3). it worked fine on macOS, Windows and Ubuntu for me. Zoom level persisted event on different sessions and after restart. by the way, I pushed fixes for (1) and (2). |
…nvs shown in list before restart
Some more comments:
|
As you also mentioned in your next comment, currently only single session window is supported. I am planning to add multiple window support in the next release. but I will see if I can include in this PR. I am thinking of adding You can click on the jlab view or hit Escape to close to Python env list. but I will also make sure title bar clicks hide it as well. |
Just FYI, I will be staying with build prior to 1b2b2a8 and possibly apply patches locally as having multiple sessions is a critical feature for me.
Sounds like a good idea. FYI, on Ubuntu for example when I click on the icon in the OS launcher it already has a "New Window" option and it already worked like that prior to 1b2b2a8: |
@krassowski hiding the env select popup when titlebar is clicked turned out to be quite complex. It works on macOS but not on Linux / Windows. Since it is a window drag region, mouse events are not being received by the listeners. I will try multiple window support in another PR but before releasing these changes. it will most likely be relatively easy thanks to this PR, but I have to try and see. This PR makes event handling specific to the SessionWindow, designed for the multiple windows. By the way, I wouldn't stay before 1b2b2a8 . Because multiple instances would modify the shared app-data.json and settings.json files which may cause issues. |
Sessions
Welcome Page
First Launch Screen
Configuration Changes
CLI Changes
jlab --help
with examplesConnect to existing JupyterLab Server
Registry
Server Status on title bar
Startup Mode
Progress View
sendMessageToMain
method to enable action linksArchitectural Changes
Tasks