-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for JupyterLab 0.35 #162
Conversation
From the update-dependency script in @jupyterlab/buildutils: update-dependency.js --lerna --minimal --regex '^@jupyterlab/' ^next
I did: <edit package.json to update the @types/react resolution> git clean -dfx yarn install yarn check yarn-tools fix-duplicates yarn.lock > a mv a yarn.lock git clean -dfx yarn install
Was the plan to do a release against the pre-releases of JLab, and then another against final? cf jupyterlab/jupyterlab#5142 (comment) |
No, I think we don't need to do two releases of these extensions. I did this update to (a) check my update-dependency script works and (b) to sanity-check the jlab prerelease. I thought I might as well push to a PR to back up my work. My thought was that we go ahead with the final js package releases (perhaps on the |
Immediately, this solves the error at https://travis-ci.org/jupyterlab/jupyter-renderers/builds/437449573#L431. See conda-forge/testpath-feedstock#6 and conda-forge/testpath-feedstock#8 for details. In general, I think it's good to test against the open conda-forge packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
All packages released! |
See the commit messages for an idea of the commands I ran to update these:
edit package.json to update the @types/react resolution