Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for JupyterLab 0.35 #162

Merged
merged 6 commits into from
Oct 5, 2018
Merged

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Oct 4, 2018

See the commit messages for an idea of the commands I ran to update these:

update-dependency --lerna --minimal --regex '^@jupyterlab/' ^next
update-dependency --lerna typescript ~3.1.1

edit package.json to update the @types/react resolution

git clean -dfx
yarn install
yarn check
yarn-tools fix-duplicates yarn.lock > a
mv a yarn.lock
git clean -dfx
yarn install

From the update-dependency script in @jupyterlab/buildutils:

update-dependency.js --lerna --minimal --regex '^@jupyterlab/' ^next
I did:

<edit package.json to update the @types/react resolution>

git clean -dfx
yarn install
yarn check
yarn-tools fix-duplicates yarn.lock > a
mv a yarn.lock
git clean -dfx
yarn install
@blink1073
Copy link
Contributor

Was the plan to do a release against the pre-releases of JLab, and then another against final? cf jupyterlab/jupyterlab#5142 (comment)

@jasongrout
Copy link
Contributor Author

No, I think we don't need to do two releases of these extensions. I did this update to (a) check my update-dependency script works and (b) to sanity-check the jlab prerelease. I thought I might as well push to a PR to back up my work. My thought was that we go ahead with the final js package releases (perhaps on the next dist-tag), then update extensions to the final release version numbers in PRs.

Immediately, this solves the error at https://travis-ci.org/jupyterlab/jupyter-renderers/builds/437449573#L431. See conda-forge/testpath-feedstock#6 and conda-forge/testpath-feedstock#8 for details.

In general, I think it's good to test against the open conda-forge packages.
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 1ea85ef into jupyterlab:master Oct 5, 2018
@blink1073
Copy link
Contributor

All packages released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants