Extract out ICollaborativeDrive to `@jupyter/collaborative-drive` #353

davidbrochart · 2024-09-16T20:25:44Z

github-actions · 2024-09-16T20:25:57Z

👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/extract-icollaborativedrive

davidbrochart · 2024-09-17T08:08:46Z

Should there be a new projects/jupyter-collaborativedrive?

davidbrochart · 2024-09-18T12:56:15Z

I'm wondering if this failure:

Error: src/yprovider.ts(6,35): error TS2307: Cannot find module '@jupyter/collaborativedrive' or its corresponding type declarations.
Error: src/ydrive.ts(16,8): error TS2307: Cannot find module '@jupyter/collaborativedrive' or its corresponding type declarations.

is caused by the fact that @jupyter/collaborativedrive is not yet published to NPM?
I cannot reproduce it, it works locally.

davidbrochart · 2024-10-04T09:36:41Z

@krassowski What do you think about getting this in before releasing v3?
We would need to publish @jupyter/collaborativedrive to NPM.

davidbrochart · 2024-10-07T08:24:40Z

@jtpio do you have the rights to publish @jupyter/collaborativedrive to NPM?

jtpio · 2024-10-07T15:20:03Z

packages/collaborativedrive/package.json

@@ -0,0 +1,55 @@
+{
+  "name": "@jupyter/collaborativedrive",


Maybe we should rename the package to the following, so it reads better, before publishing it?

Suggested change

"name": "@jupyter/collaborativedrive",

"name": "@jupyter/collaborative-drive",

Fine with me 👍

davidbrochart · 2024-10-08T08:34:57Z

@krassowski @jtpio ok to merge and publish @jupyter/collaborative-drive?

davidbrochart · 2024-10-09T09:39:45Z

I'm planning to merge today.

jtpio · 2024-10-09T14:14:31Z

Thanks @davidbrochart. I'll try to have another look today.

krassowski · 2024-10-09T16:09:43Z

.github/workflows/test.yml

@@ -71,6 +71,7 @@ jobs:
          pip install "jupyterlab>=4.0.0,<5"
          pip install -e .
          jlpm
+          jlpm build


Why do we need it here?

I don't remember the reason, I'll remove it to see what happens.

See here:

src/yprovider.ts:6:35 - error TS2307: Cannot find module '@jupyter/collaborative-drive' or its corresponding type declarations. 6 import { IDocumentProvider } from '@jupyter/collaborative-drive'; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Maybe it will be fine once @jupyter/collaborative-drive is published?

Ah, maybe I can help publish a placeholder version to see if it helps.

It looks like a version with the previous name was also published earlier: https://www.npmjs.com/package/@jupyter/collaborativedrive

Maybe it can be removed from npm so it's less confusing?

Now I'm confused, who published that? Do we use it somewhere?

Now I'm confused, who published that? Do we use it somewhere?

Looks like you did?

I guess you published it to see if that would help fix the CI?

Maybe, I don't remember.

jtpio · 2024-10-09T21:47:36Z

packages/collaborativedrive/package.json

Let's rename the folder from:

packages/collaborativedrive

To

packages/collaborative-drive

So it's consistent with the package name?

davidbrochart · 2024-10-10T07:30:04Z

Same error:

    src/yprovider.ts:6:35 - error TS2307: Cannot find module '@jupyter/collaborative-drive' or its corresponding type declarations.
    6 import { IDocumentProvider } from '@jupyter/collaborative-drive';
                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I guess the published package is useless without code. I'll add jlpm build back.

jtpio · 2024-10-10T15:38:43Z

I guess the published package is useless without code.

What do you mean by "without code"? The package was published from this branch directly.

davidbrochart · 2024-10-10T15:41:06Z

Oh my bad, yes the code is there. Then I don't know what is wrong.

jtpio · 2024-10-10T15:51:19Z

Having to add jlpm run build makes it look like something is wrong in the setup of the new package, since it was not needed before.

jtpio · 2024-10-10T15:52:46Z

yarn.lock

@@ -2122,10 +2123,22 @@ __metadata:
  languageName: unknown
  linkType: soft

+"@jupyter/collaborative-drive@^3.0.0-beta.6, @jupyter/collaborative-drive@workspace:packages/collaborative-drive":


This line looks different than for the other packages.

Good catch, let's try to make it similar.

So it's Yarn that adds @jupyter/collaborative-drive@^3.0.0-beta.6.

davidbrochart · 2024-10-11T07:43:29Z

I guess the published package is useless without code.

What do you mean by "without code"? The package was published from this branch directly.

Actually yes, there is no code here.

davidbrochart · 2024-10-11T08:13:53Z

I published @jupyter/collaborative-drive v3.0.0-beta.7, and there is no IDocumentProvider in lib/tokens.js here. It is in lib/tokens.d.ts but it's not enough, right?

davidbrochart · 2024-10-11T13:24:54Z

In the end, I just think that jlpm build is needed because the test in docprovider now needs @jupyter/collaborative-drive through yprovider.ts, so it has to be compiled.

davidbrochart · 2024-10-11T13:52:40Z

I'll take the risk to merge this PR and release jupyter-collaboration v3.0.0beta7. We can still revert the changes and release v3.0.0beta8 if it doesn't work.

jtpio · 2024-10-11T14:28:33Z

Arf, I wanted to help you more on this yesterday but didn't have time.

At the very least it would have been great to leave a TODO, or open an issue...

Maybe check the tsconfig.json to see if it needs a references?

davidbrochart marked this pull request as draft September 16, 2024 20:25

davidbrochart force-pushed the extract-icollaborativedrive branch from 4bb9690 to b0b5c7a Compare September 17, 2024 07:30

davidbrochart added the maintenance label Sep 17, 2024

davidbrochart force-pushed the extract-icollaborativedrive branch 3 times, most recently from cf02af4 to de0c62e Compare September 17, 2024 07:46

davidbrochart marked this pull request as ready for review September 17, 2024 07:46

davidbrochart force-pushed the extract-icollaborativedrive branch from de0c62e to 13fe0c4 Compare September 17, 2024 07:58

davidbrochart mentioned this pull request Sep 17, 2024

Final v3.0.0 release #354

Open

davidbrochart force-pushed the extract-icollaborativedrive branch 6 times, most recently from eb1976f to b0f2621 Compare September 18, 2024 09:19

davidbrochart force-pushed the extract-icollaborativedrive branch 3 times, most recently from 484d489 to 95c62d1 Compare September 18, 2024 13:51

davidbrochart force-pushed the extract-icollaborativedrive branch from 95c62d1 to cece00b Compare October 3, 2024 14:26

Extract out ICollaborativeDrive to @jupyter/collaborativedrive

32a3e5a

davidbrochart force-pushed the extract-icollaborativedrive branch from 581484c to 32a3e5a Compare October 4, 2024 09:17

jtpio reviewed Oct 7, 2024

View reviewed changes

davidbrochart force-pushed the extract-icollaborativedrive branch from 0997374 to d08c6a8 Compare October 7, 2024 16:07

Rename @jupyter/collaborativedrive to @jupyter/collaborative-drive

6cd68c2

davidbrochart force-pushed the extract-icollaborativedrive branch from d08c6a8 to 6cd68c2 Compare October 7, 2024 16:20

krassowski reviewed Oct 9, 2024

View reviewed changes

Remove jlpm build

b670b40

jtpio changed the title ~~Extract out ICollaborativeDrive to @jupyter/collaborativedrive~~ Extract out ICollaborativeDrive to @jupyter/collaborative-drive Oct 9, 2024

jtpio reviewed Oct 9, 2024

View reviewed changes

Move packages/collaborativedrive -> packages/collaborative-drive

b1f410d

Add back jlpm build

dbf2e1b

jtpio reviewed Oct 10, 2024

View reviewed changes

davidbrochart and others added 3 commits October 10, 2024 18:00

-

a31f286

update yarn.lock

c83948e

Update collaborative-drive dependencies

dc8f7a1

davidbrochart force-pushed the extract-icollaborativedrive branch from c380720 to dc8f7a1 Compare October 10, 2024 20:19

Add collaborative-drive as shared package

4798ee3

-

4c685ca

davidbrochart force-pushed the extract-icollaborativedrive branch from c8514d5 to 4c685ca Compare October 11, 2024 07:55

-

3e85e56

davidbrochart merged commit 60e55ea into jupyterlab:main Oct 11, 2024
18 of 20 checks passed

davidbrochart deleted the extract-icollaborativedrive branch October 11, 2024 14:08

jtpio mentioned this pull request Oct 21, 2024

Remove the extra jlpm run build in the workflow #380

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract out ICollaborativeDrive to `@jupyter/collaborative-drive` #353

Extract out ICollaborativeDrive to `@jupyter/collaborative-drive` #353

davidbrochart commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

davidbrochart commented Sep 17, 2024

davidbrochart commented Sep 18, 2024

davidbrochart commented Oct 4, 2024

davidbrochart commented Oct 7, 2024

jtpio Oct 7, 2024

davidbrochart Oct 7, 2024

davidbrochart commented Oct 8, 2024

davidbrochart commented Oct 9, 2024

jtpio commented Oct 9, 2024

krassowski Oct 9, 2024

davidbrochart Oct 9, 2024

davidbrochart Oct 9, 2024

davidbrochart Oct 9, 2024

jtpio Oct 9, 2024

jtpio Oct 9, 2024

davidbrochart Oct 10, 2024

jtpio Oct 10, 2024

jtpio Oct 10, 2024

davidbrochart Oct 10, 2024

jtpio Oct 9, 2024

davidbrochart commented Oct 10, 2024

jtpio commented Oct 10, 2024

davidbrochart commented Oct 10, 2024

jtpio commented Oct 10, 2024

jtpio Oct 10, 2024

davidbrochart Oct 10, 2024

davidbrochart Oct 10, 2024

davidbrochart commented Oct 11, 2024 •

edited

Loading

davidbrochart commented Oct 11, 2024

davidbrochart commented Oct 11, 2024

davidbrochart commented Oct 11, 2024

jtpio commented Oct 11, 2024

	"name": "@jupyter/collaborativedrive",
	"name": "@jupyter/collaborative-drive",

Extract out ICollaborativeDrive to @jupyter/collaborative-drive #353

Extract out ICollaborativeDrive to @jupyter/collaborative-drive #353

Conversation

davidbrochart commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

davidbrochart commented Sep 17, 2024

davidbrochart commented Sep 18, 2024

davidbrochart commented Oct 4, 2024

davidbrochart commented Oct 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidbrochart commented Oct 8, 2024

davidbrochart commented Oct 9, 2024

jtpio commented Oct 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidbrochart commented Oct 10, 2024

jtpio commented Oct 10, 2024

davidbrochart commented Oct 10, 2024

jtpio commented Oct 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidbrochart commented Oct 11, 2024 • edited Loading

davidbrochart commented Oct 11, 2024

davidbrochart commented Oct 11, 2024

davidbrochart commented Oct 11, 2024

jtpio commented Oct 11, 2024

Extract out ICollaborativeDrive to `@jupyter/collaborative-drive` #353

Extract out ICollaborativeDrive to `@jupyter/collaborative-drive` #353

davidbrochart commented Oct 11, 2024 •

edited

Loading