Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle generic document types in timeline #349

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Handle generic document types in timeline #349

merged 1 commit into from
Sep 17, 2024

Conversation

davidbrochart
Copy link
Collaborator

Fixes #348.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Binder 👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/timeline

@davidbrochart davidbrochart added the enhancement New feature or request label Sep 9, 2024
@davidbrochart
Copy link
Collaborator Author

@Meriem-BenIsmail feel free to review this PR if you wish so :)

@Meriem-BenIsmail
Copy link
Contributor

I think this looks good @davidbrochart .

@davidbrochart
Copy link
Collaborator Author

Great, do you want to approve the PR?

@davidbrochart davidbrochart merged commit 682d14d into jupyterlab:main Sep 17, 2024
19 of 21 checks passed
@davidbrochart davidbrochart deleted the timeline branch September 17, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meriem-BenIsmail Meriem-BenIsmail Meriem-BenIsmail approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference to JCAD document type
2 participants
@davidbrochart @Meriem-BenIsmail