Fix bump file

[brichet]

Fix the dependencies in jupyter_collaboration metapackage, and fix the bump script.

Initially discussed at #342 (comment)

cc. @krassowski

[github-actions]

👈 Launch a Binder on branch brichet/jupyter_collaboration/fix_bump

[brichet]

Any clue on the check-release failure ?

I can't reproduce the steps locally, so it's hard to debug.

[jtpio]

Any clue on the check-release failure ?

This seems to be failing as part of the check-python step, and related to jupyter-server/jupyter_releaser#499.

Which was also noticed in voila-dashboards/voici#106.

A workaround for now could be to disable the check-python step. Until there is a way to skip the pip install in the releaser, or be able to install all packages of the monorepo at once in this check.

[brichet]

Thanks for your feedback @jtpio.

A workaround for now could be to disable the check-python step. Until there is a way to skip the pip install in the releaser, or be able to install all packages of the monorepo at once in this check.

I'll see if I can find a way to keep this check, otherwise we'll probably ignore it until there's a fix on the releaser.

[krassowski]

So instead of skipping the check-python I wonder if we can tell pip to include a local registry using --extra-index-url or --find-links pointing to the local file system on the runner. This too may require a change in releaser, but that would be probably beneficial to many other packages (like jupyter-ai and voila) so I think it is worth it.

[davidbrochart]

It looks like we are missing the pre-release specifier:

ERROR: Could not find a version that satisfies the requirement jupyter-collaboration-ui>=1.0.0 (from jupyter-collaboration) (from versions: 1.0.0a0, 1.0.0a1, 1.0.0a2, 1.0.0b0, 1.0.0b1, 1.0.0b2, 1.0.0b3, 1.0.0b4, 1.0.0b5, 1.0.0b6)
ERROR: No matching distribution found for jupyter-collaboration-ui>=1.0.0

[brichet]

It looks like we are missing the pre-release specifier:

ERROR: Could not find a version that satisfies the requirement jupyter-collaboration-ui>=1.0.0 (from jupyter-collaboration) (from versions: 1.0.0a0, 1.0.0a1, 1.0.0a2, 1.0.0b0, 1.0.0b1, 1.0.0b2, 1.0.0b3, 1.0.0b4, 1.0.0b5, 1.0.0b6)
ERROR: No matching distribution found for jupyter-collaboration-ui>=1.0.0

Yes, we still have an issue because of the releaser that doesn't allow installing local python package with pip (AFAIK): #343 (comment)

[davidbrochart]

So do you think we should merge anyway?

[jtpio]

It would be better to get that check-release check green, to give more confidence when making releases and catching potential other issues.

[davidbrochart]

@brichet do you think we should merge (after rebase)?

[brichet]

Do you know if the check-python test has been updated on the releaser ?
Otherwise we need to ignore this test to avoid all the following PR to fail, but I'm not sure there is a consensus about that.

[davidbrochart]

I don't know. Was the error the following?

ERROR: Could not find a version that satisfies the requirement jupyter-collaboration-ui>=1.0.0 (from jupyter-collaboration) (from versions: 1.0.0a0, 1.0.0a1, 1.0.0a2, 1.0.0b0, 1.0.0b1, 1.0.0b2, 1.0.0b3, 1.0.0b4, 1.0.0b5, 1.0.0b6, 1.0.0b8)
ERROR: No matching distribution found for jupyter-collaboration-ui>=1.0.0

[jtpio]

jupyter-server/jupyter_releaser#499 is still opened and there is no work-in-progress to fix this on the releaser at the moment.

The easiest workaround for now would likely be to skip the check-python step (and open a new issue to track removing it), to make sure check_release passes on CI.

[davidbrochart]

Thanks!