Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fileId instead of path in the store #174

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

hbcarlos
Copy link
Member

fixes #165

Use fileId instead of path in the store.

If we use the path instead of the file ID, when renaming the file and creating a new file with the old name, the new file will have the updates of the old one (Kind of. If the content on disk differs from the store, the disk has priority).

@hbcarlos hbcarlos added the bug Something isn't working label Jun 29, 2023
@hbcarlos hbcarlos self-assigned this Jun 29, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch hbcarlos/jupyter-collaboration/fix#165_

@hbcarlos hbcarlos requested a review from fcollonval June 29, 2023 17:07
@SylvainCorlay
Copy link
Member

As per discussion with Carlos, if this gets in, it may require a change in jupyverse. Ping @davidbrochart for awareness.

@davidbrochart
Copy link
Collaborator

Jupyverse already implements this here. I suggest to get rid of path.parent:

updates_file_path = f".{file_type}:{file_id}.y"

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

@davidbrochart davidbrochart merged commit 5c67797 into jupyterlab:main Jul 5, 2023
@hbcarlos hbcarlos deleted the fix_#165 branch July 5, 2023 10:29
@hbcarlos hbcarlos added this to the 2.0.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behaviour after renaming a file.
3 participants