Handle edition and deletion of message in collaborative chat extension

jupyterlab · Apr 25, 2024 · 794fb74 · 794fb74
1 parent 2a9c263
commit 794fb74
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 4 deletions.
diff --git a/packages/jupyter-chat/src/components/chat.tsx b/packages/jupyter-chat/src/components/chat.tsx
@@ -55,20 +55,24 @@ function ChatBody({
       if (message.type === 'clear') {
         setMessages([]);
         return;
-      } else if (message.type === 'msg') {
+      } else {
         setMessages((messageGroups: IChatMessage[]) => {
           const existingMessages = [...messageGroups];
 
           const messageIndex = existingMessages.findIndex(
             msg => msg.id === message.id
           );
           if (messageIndex > -1) {
-            // The message is an update of an existing one.
-            // Let's remove it (to avoid position conflict if timestamp has changed)
-            // and add the new one.
+            // The message is an update of an existing one (or a removal).
+            // Let's remove it anyway (to avoid position conflict if timestamp has
+            // changed) and add the new one if it is an update.
             existingMessages.splice(messageIndex, 1);
           }
 
+          if (message.type === 'remove') {
+            return existingMessages;
+          }
+
           // Find the first message that should be after this one.
           let nextMsgIndex = existingMessages.findIndex(
             msg => msg.time > message.time

diff --git a/packages/jupyterlab-collaborative-chat/src/model.ts b/packages/jupyterlab-collaborative-chat/src/model.ts
@@ -167,6 +167,30 @@ export class CollaborativeChatModel
     this.sharedModel.transact(() => void this.sharedModel.setMessage(msg));
   }
 
+  updateMessage(
+    id: string,
+    message: IChatMessage
+  ): Promise<boolean | void> | boolean | void {
+    let sender: string;
+    if (typeof message.sender === 'string') {
+      sender = message.sender;
+    } else {
+      sender = message.sender.username;
+    }
+    const msg: IYmessage = {
+      type: 'msg',
+      id: id || UUID.uuid4(),
+      body: message.body,
+      time: message.time || Date.now() / 1000,
+      sender: sender
+    };
+    this.sharedModel.transact(() => void this.sharedModel.setMessage(msg));
+  }
+
+  deleteMessage(id: string): Promise<boolean | void> | boolean | void {
+    this.sharedModel.transact(() => void this.sharedModel.deleteMessage(id));
+  }
+
   private _onchange = (_: YChat, change: ChatChange) => {
     if (change.messageChanges) {
       const msgChange = change.messageChanges;

diff --git a/packages/jupyterlab-collaborative-chat/src/ychat.ts b/packages/jupyterlab-collaborative-chat/src/ychat.ts
@@ -96,6 +96,10 @@ export class YChat extends YDocument<ChatChange> {
     this._messages.set(value.id, value);
   }
 
+  deleteMessage(id: string): void {
+    this._messages.delete(id);
+  }
+
   private _usersObserver = (event: Y.YMapEvent<IUser>): void => {
     const userChange = new Array<UserChange>();
     event.keysChanged.forEach(key => {