Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish between completion and chat models #711

Merged
merged 21 commits into from
May 3, 2024
Merged

Distinguish between completion and chat models #711

merged 21 commits into from
May 3, 2024

Commits on Apr 10, 2024

  1. Distinguish between completion and chat models

    @krassowski
    krassowski committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    213891c View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @krassowski
    krassowski committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2c196ef View commit details
    Browse the repository at this point in the history

  3. Shorten the tab name, move settings button 

    Lint
    @krassowski
    krassowski committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    578f63c View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Implement the completion model selection in chat UI

    @krassowski
    krassowski committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    575f3f4 View commit details
    Browse the repository at this point in the history

  2. Improve docstring

    @krassowski
    krassowski committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9b90e4d View commit details
    Browse the repository at this point in the history

  3. Call _validate_lm_em_id only once, add typing annotations

    @krassowski
    krassowski committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9882134 View commit details
    Browse the repository at this point in the history

  4. Remove embeddings provider for completions 

    as the team has no plans to support it :(
    @krassowski
    krassowski committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ac7cd84 View commit details
    Browse the repository at this point in the history

  5. Use type alias to reduce changeset/make review easier 

    Without this change prettier reformats the plugin with an extra
indentation, which leads to bad changeset display on GitHub.
    @krassowski
    krassowski committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    59156f9 View commit details
    Browse the repository at this point in the history

  6. Rename _validate_lm_em_id to _validate_model_ids

    @krassowski
    krassowski committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b06481a View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge branch 'main' into separate-completer-and-chat-settings

    @krassowski
    krassowski committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c410441 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Rename LLMHandlerMixin to CompletionsModelMixin 

    and rename the file from `llm_mixin` to `model_mixin` fro consistency.
Of note, the file name does not need `completions_` prefix as the file
is in `completions/` subdirectory.
    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ec5b1b8 View commit details
    Browse the repository at this point in the history

  2. Rename "Chat LM" to "LM"; add title attribute; note 

    using the title attribute because getting the icon to show up nicely
(getting they nice grey color and positioning as it gets in buttons,
compared to just plain black) was not trivial; I think the icon might
be the way to go in the future but I would postpone it to another PR.

That said, I still think it should say "Chat LM" because it has no
effect on magics nor completions.
    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    84165e5 View commit details
    Browse the repository at this point in the history

  3. Rename heading "Completer model" → "Inline completions model"

    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    41ecf03 View commit details
    Browse the repository at this point in the history

  4. Move UseSignal down to CompleterSettingsButton implementation

    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8d727d3 View commit details
    Browse the repository at this point in the history

  5. Rename the label in the select to "Inline completion model"

    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a9dc569 View commit details
    Browse the repository at this point in the history

  6. Disable selection when completer is not enabled

    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    13d0ecf View commit details
    Browse the repository at this point in the history

  7. Remove use of UseSignal, tweak naming of useState 

    from `completerIsEnabled` to `isCompleterEnabled`
    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    92fa8c6 View commit details
    Browse the repository at this point in the history

  8. Use mui tooltips

    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    18e57f4 View commit details
    Browse the repository at this point in the history

  9. Fix use of jai_config_manager

    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5ac3cf3 View commit details
    Browse the repository at this point in the history

  10. Fix tests

    @krassowski
    krassowski committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b5587fc View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into separate-completer-and-chat-settings

    @krassowski
    krassowski authored May 2, 2024
    Configuration menu
    Copy the full SHA
    32b28b9 View commit details
    Browse the repository at this point in the history