Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the Ollama base URL #1008

Closed
wants to merge 1 commit into from

Conversation

sqlreport
Copy link

#1004

  • import TextField from providers
  • add base_url to allow custom url for ollama embeddings provider

- import TextField from providers
- add base_url to allow custom url for ollama embeddings provider
@sqlreport sqlreport marked this pull request as ready for review September 20, 2024 14:37
@sqlreport
Copy link
Author

sqlreport commented Sep 20, 2024

I am unable to update the label. Can maintainers help on this? @dlqqq / @krassowski / @srdas / @3coins

@srdas srdas added the enhancement New feature or request label Sep 20, 2024
@dlqqq
Copy link
Member

dlqqq commented Sep 20, 2024

@sqlreport The issue you linked (langchain-ai/langchain#25022) seems to imply that the LangChain class does not accept a base_url keyword argument, which is how config fields get passed to LangChain in Jupyter AI. If the upstream LangChain class doesn't support overriding the base URL, then adding this field won't allow you to use a different base URL.

Have you tested this branch locally to see if you're able to use a different base URL for Ollama embeddings? If so, I can approve and merge this.

@hockeymomonow
Copy link

@dlqqq I have verified the fix on my jlpm dev environment.
Screenshot from 2024-09-26 22-08-33

@hockeymomonow
Copy link

Screenshot from 2024-09-26 22-08-51

@sqlreport
Copy link
Author

closing the PR as main shifted too much

@sqlreport sqlreport closed this Sep 26, 2024
@sqlreport sqlreport deleted the patch-2 branch October 5, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants