Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to jlab 0.35 and typescript 3.1.1 #41

Merged
merged 4 commits into from
Oct 5, 2018

Conversation

jasongrout
Copy link
Contributor

No description provided.

@blink1073 blink1073 mentioned this pull request Oct 3, 2018
31 tasks
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saulshanabrook
Copy link
Member

Are we waiting on anything else to merge this? @jzf2101 was wondering what JL version to user in her tutorial and I think if this gets merged beforehand she should use the latest whereas if it doesn't she should use the older version.

@jzf2101
Copy link
Contributor

jzf2101 commented Oct 4, 2018

@jasongrout ready to merge?

@jasongrout
Copy link
Contributor Author

@jasongrout ready to merge?

Not quite yet. We should (a) publish final js packages, then (b) update this PR to refer to those final packages.

That said, I think it would technically work if we merged this PR and you used the RC.

@jasongrout
Copy link
Contributor Author

I think this is ready to merge now

@jasongrout
Copy link
Contributor Author

Well, I guess the install steps call for it to be merged after the jlab 0.35 python package is published, so maybe not quite yet.

@jasongrout
Copy link
Contributor Author

Well, it looks like we need this in order to update other things, so I'll merge this. I added some instructions for what to do if you want a version for another jlab release.

@jasongrout jasongrout merged commit 9667391 into jupyterlab:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants