Add line highlight for breakpoints #94
Conversation
src/debugger.ts
Outdated
| @@ -172,6 +176,7 @@ export namespace Debugger { | |||
| private _session: IDebugger.ISession | null; | |||
| private _sessionChanged = new Signal<this, void>(this); | |||
| private _service = new DebugService(null, this); | |||
| private _selectCurrentLine = new Signal<this, number>(this); | |||
There was a problem hiding this comment.
How about this name to follow the other conventions?
| private _selectCurrentLine = new Signal<this, number>(this); | |
| private _currentLineChanged = new Signal<this, number>(this); |
I think it makes sense to have it there for now and let the service update the model. Later the service will be able to:
The views would listen to changes on their model and reflect the updates. |
jtpio
changed the title
jtpio
changed the title
jtpio
changed the title
|
Note that this change doesn't remove the line highlighting when the debugger stops. We'll need some kind of cleanup handler for that. |
src/handlers/cell.ts
Outdated
| @@ -36,6 +43,24 @@ export class CellManager implements IDisposable { | |||
| private _activeCell: CodeCell; | |||
| isDisposed: boolean; | |||
|
|
|||
| showCurrentLine(lineNumber: number) { | |||
There was a problem hiding this comment.
Could this method actually be private?
KsavinN
changed the title
|
Going to rebase this one to fix the conflicts. |
|
After getting the latest changes from master (tree view):
|
|
resolved:
#85
In future:
#86
I add simple Highline. Signal instance is created in the model of the debugger. Emitting is placed in service and signal is connected in cell handler. Is that proper way or should we consider about another architecture?