This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Create Service for control signals between session and UI #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge iteration
jtpio
reviewed
Oct 18, 2019
jtpio
reviewed
Oct 21, 2019
jtpio
reviewed
Oct 21, 2019
|
Resolved issue #73 |
get iterration
This was referenced Oct 21, 2019
Closed
jtpio
reviewed
Oct 21, 2019
jtpio
reviewed
Oct 22, 2019
jtpio
reviewed
Oct 22, 2019
|
@KsavinN is there anything else you wanted to add before we could wrap it up? We've got the initial structure for viewing the state of the variables which is good. We could iterate on the rest in a separate change. |
|
This will fix #44 |
@jtpio I will just change code by your suggestion and end that PR. After that, I want focus already on implement react-inspector |
|
@jtpio Are you think we can merge that? |
|
I will do a quick check locally first. |
jtpio
changed the title
jtpio
reviewed
Oct 22, 2019
jtpio
reviewed
Oct 22, 2019
|
Merging as is, and opened these issues to follow-up: |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we can get scopes,variables by command "Launch".
The proper work is described in #64 .