Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Install libgbm1 to fix puppeteer in tests #428

Closed
wants to merge 2 commits into from
Closed

Install libgbm1 to fix puppeteer in tests #428

wants to merge 2 commits into from

Conversation

afshin
Copy link
Member

@afshin afshin commented Apr 21, 2020

Install libgbm1 to fix puppeteer.

@afshin afshin closed this Apr 21, 2020
@jtpio
Copy link
Member

jtpio commented Apr 21, 2020

Strange, the PR is shown as "Closed", but was merged?

It might be related to today's GitHub incident though.

@jtpio
Copy link
Member

jtpio commented Apr 21, 2020

Thanks for the fix by the way!

@afshin
Copy link
Member Author

afshin commented Apr 21, 2020 via email

@jtpio jtpio mentioned this pull request Apr 22, 2020
Closed
@jtpio
Copy link
Member

jtpio commented Apr 24, 2020

We should now be able to undo this change, as the latest CI runs now pull JupyterLab 2.1.1: https://github.com/jupyterlab/debugger/pull/415/checks?check_run_id=615387049

Which includes the puppeteer fix: jupyterlab/jupyterlab#8244 (comment)

@tgeorgeux tgeorgeux mentioned this pull request Apr 29, 2020
Closed
@jtpio jtpio mentioned this pull request May 19, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afshin @jtpio