Resolve issues with Notebook Handler #163

KsavinN · 2019-11-08T11:16:47Z

Fixes #133
Fixes #122

and resolve the

additional issue:

jtpio · 2019-11-08T12:28:57Z

The diff contains changes from other (merged) pull requests (stop button, tests).

KsavinN

The diff contains changes from other (merged) pull requests (stop button, tests).

Good catch. A branch was rebased should be ok now.

src/handlers/cell.ts

src/handlers/notebook.ts

src/handlers/cell.ts

jtpio · 2019-11-11T10:12:28Z

I left a TODO to check whether we could remove the call to requestAnimationFrame.

jtpio

KsavinN added 2 commits November 8, 2019 13:39

resolve render linenumbers issue of notebook

8be69e7

resolve issue with set breakpoints after dispose notebook

af44178

KsavinN commented Nov 8, 2019

View reviewed changes

src/handlers/cell.ts Outdated Show resolved Hide resolved

src/handlers/notebook.ts Outdated Show resolved Hide resolved

resolve hover issue in console and editor error

d4ffc8b

KsavinN changed the title ~~[WIP] Resolve issues~~ Resolve issues with Notebook Handler Nov 8, 2019

jtpio reviewed Nov 11, 2019

View reviewed changes

src/handlers/cell.ts Outdated Show resolved Hide resolved

jtpio added 2 commits November 11, 2019 10:47

Add TODO for the requestAnimationFrame

140cee3

Change cell.disposed to cell.isDisposed

8e1ad3c

jtpio approved these changes Nov 11, 2019

View reviewed changes

jtpio merged commit f641270 into jupyterlab:master Nov 11, 2019

KsavinN mentioned this pull request Nov 12, 2019

Handlers issue #102

Closed

Provide feedback