Skip to content

Commit

Permalink
Clean up workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval committed Aug 15, 2023
1 parent 2d3256d commit 0eb78f0
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 74 deletions.
29 changes: 0 additions & 29 deletions .github/workflows/binder-on-pr.yaml

This file was deleted.

75 changes: 70 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,12 @@ jobs:
jupyter labextension list 2>&1 | grep -ie "@hadim/jupyter-archive.*OK"
python -m jupyterlab.browser_check --no-browser-test
integration-tests:
name: Integration tests
integration-tests-lab:
name: Integration tests for JupyterLab
strategy:
fail-fast: false
matrix:
jupyterlab: ['3.6', '4.0']
needs: build
runs-on: ubuntu-latest

Expand All @@ -107,13 +111,17 @@ jobs:
- name: Install the extension
run: |
set -eux
python -m pip install "jupyterlab>=4.0.0,<5" jupyter_archive*.whl
python -m pip install "jupyterlab~=${{ matrix.jupyterlab }}" jupyter_archive*.whl
- name: Install dependencies
working-directory: ui-tests
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
run: jlpm install
run: |
if [[ "${{ matrix.jupyterlab }}" == "3.6" ]]; then
jlpm add -D "@jupyterlab/galata@^4.0.0"
fi
jlpm install
- name: Set up browser cache
uses: actions/cache@v3
Expand All @@ -129,13 +137,70 @@ jobs:
- name: Execute integration tests
working-directory: ui-tests
run: |
jlpm playwright test
jlpm playwright test --output test-results-${{ matrix.jupyterlab }}
- name: Upload Playwright Test report
if: always()
uses: actions/upload-artifact@v3
with:
name: jupyter-archive-playwright-tests
path: |
ui-tests/test-results*
ui-tests/playwright-report
integration-tests-nb:
name: Integration tests for Notebook
needs: build
runs-on: ubuntu-latest

env:
PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/pw-browsers

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Download extension package
uses: actions/download-artifact@v3
with:
name: extension-artifacts

- name: Install the extension
run: |
set -eux
python -m pip install "notebook~=7.0" jupyterlab_tour*.whl
- name: Install dependencies
working-directory: ui-tests
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
run: |
jlpm install
- name: Set up browser cache
uses: actions/cache@v3
with:
path: |
${{ github.workspace }}/pw-browsers
key: ${{ runner.os }}-${{ hashFiles('ui-tests/yarn.lock') }}

- name: Install browser
run: jlpm playwright install chromium
working-directory: ui-tests

- name: Execute integration tests
working-directory: ui-tests
run: |
jlpm playwright test -c playwright-notebook.config.js
- name: Upload Playwright Test report
if: always()
uses: actions/upload-artifact@v3
with:
name: notebook-tour-playwright-tests
path: |
ui-tests/test-results
ui-tests/playwright-report
Expand Down
40 changes: 0 additions & 40 deletions .github/workflows/publish.yml

This file was deleted.

0 comments on commit 0eb78f0

Please sign in to comment.