Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'kind get kubeconfig' instead of deprecated 'kubeconfig-path' #1651

Closed
wants to merge 2 commits into from

Conversation

stv0g
Copy link
Contributor

@stv0g stv0g commented Apr 30, 2020

kind get kubeconfig-path has been removed in kubernetes-sigs/kind@e258374

The PR uses kind get kubeconfig and writes the contents into a local file.

Closes #1650

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, CI tests are still passing with the current version of kind 👍 .

What do you think about moving the duplicated code into a new method e.g. get_kubeconfig() or get_kubeconfig_path()?

@stv0g
Copy link
Contributor Author

stv0g commented May 12, 2020

Hi @manics,

I refactored the duplicated code into a new function as you proposed.

@consideRatio
Copy link
Member

@stv0g thank you for your contribution and @manics for your review! ❤️

I've felt that the local development experience with this dev script and the way it use kind isn't good enough, and suggest we kill it entirely in favor of k3s (and optionally k3d which wraps k3s in docker containers).

In #1664 I'm removing the dev script and the use of kind. I created the dev script an feel it was a big failure because of how much complexity it added and how fragile it behaved. I hope that by killing it now rather than later I will spare others the time wasted on interacting with it.

With this considered, does it feel okay to close this PR @stv0g?

@stv0g
Copy link
Contributor Author

stv0g commented May 15, 2020

@consideRatio I agree.

Are you planning to use the new dev setup also for CI tests?

I was trying to get the CI tests ready for IPv6. Unfortunately, kind's IPv6 support is broken :(

@consideRatio
Copy link
Member

consideRatio commented May 15, 2020

@stv0g yepp thats the plan - local dev + CI environment.

I'm not sure about k3s ability to work with ipv6 or not, I'm very inexperienced in general about ipv6 so far.

@consideRatio
Copy link
Member

consideRatio commented May 15, 2020

Seems like bleeding edge support in k3s for ipv6 at best: k3s-io/k3s#284

@stv0g
Copy link
Contributor Author

stv0g commented May 15, 2020

At least the Rancher UI is not capable of IPv6 :(

@consideRatio
Copy link
Member

@stv0g I hope to be able to help you help everyone with the IPv6 support, I'm slowly catching up with a backlog of things to do.

@consideRatio
Copy link
Member

We have now replaced kind entirely with k3s in our CI setup, and the local dev setup instructions are updated to use k3s or k3d.

@stv0g stv0g deleted the kind-kubeconfig-path branch January 26, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kind] ERROR: unknown flag: --name
3 participants