-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'kind get kubeconfig' instead of deprecated 'kubeconfig-path' #1651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, CI tests are still passing with the current version of kind 👍 .
What do you think about moving the duplicated code into a new method e.g. get_kubeconfig()
or get_kubeconfig_path()
?
Hi @manics, I refactored the duplicated code into a new function as you proposed. |
@stv0g thank you for your contribution and @manics for your review! ❤️ I've felt that the local development experience with this In #1664 I'm removing the With this considered, does it feel okay to close this PR @stv0g? |
@consideRatio I agree. Are you planning to use the new dev setup also for CI tests? I was trying to get the CI tests ready for IPv6. Unfortunately, kind's IPv6 support is broken :( |
@stv0g yepp thats the plan - local dev + CI environment. I'm not sure about k3s ability to work with ipv6 or not, I'm very inexperienced in general about ipv6 so far. |
Seems like bleeding edge support in k3s for ipv6 at best: k3s-io/k3s#284 |
At least the Rancher UI is not capable of IPv6 :( |
@stv0g I hope to be able to help you help everyone with the IPv6 support, I'm slowly catching up with a backlog of things to do. |
We have now replaced |
kind get kubeconfig-path
has been removed in kubernetes-sigs/kind@e258374The PR uses
kind get kubeconfig
and writes the contents into a local file.Closes #1650