Give feedback to users explicitly setting autogeneratable secrets

jupyterhub · Jan 21, 2021 · 78b6d75 · 78b6d75
1 parent 227d7fc
commit 78b6d75
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/jupyterhub/templates/NOTES.txt b/jupyterhub/templates/NOTES.txt
@@ -20,6 +20,17 @@ Note that this is still an alpha release! If you have questions, feel free to
   3. File issues at https://github.com/jupyterhub/zero-to-jupyterhub-k8s/issues
 
 
+{{- if or .Values.proxy.secretToken .Values.hub.config.JupyterHub.proxy_auth_token }}{{ println }}
+NOTE: proxy.secretToken or hub.config.JupyterHub.proxy_auth_token was explicitly set, this is no longer needed.
+{{- end }}
+{{- if or .Values.hub.cookieSecret .Values.hub.config.JupyterHub.cookie_secret }}{{ println }}
+NOTE: hub.cookieSecret or hub.config.JupyterHub.cookie_secret was explicitly set, this is no longer needed.
+{{- end }}
+{{- if .Values.hub.config.CryptKeeper.keys }}{{ println }}
+NOTE: hub.config.CryptKeeper.keys was explicitly set, this is no longer needed.
+{{- end }}
+
+
 {{- if hasKey .Values.singleuser.cloudMetadata "enabled" }}{{ println }}
 DEPRECATION: singleuser.cloudMetadata.enabled is deprecated, instead use singleuser.cloudMetadata.blockWithIptables with the inverted value.
 {{- end }}

diff --git a/jupyterhub/values.yaml b/jupyterhub/values.yaml
@@ -27,6 +27,8 @@ imagePullSecrets: []
 # the proxy pod.
 hub:
   config:
+    Authenticator: {}
+    CryptKeeper: {}
     JupyterHub:
       admin_access: true
       authenticator_class: dummy