Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jupyterlab 3.0 and Jupyter Resource Usage #658

Merged
merged 5 commits into from
Mar 21, 2021

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented Feb 8, 2021

Replaces #647 with the suggested changes.

yuvipanda and others added 2 commits December 29, 2020 16:22
JupyterLab 3.0 no longer equires npm to build extensions!
This should hopefully let us reduce the memory requiremets
for TLJH.
@jtpio jtpio mentioned this pull request Feb 8, 2021
@jtpio
Copy link
Contributor Author

jtpio commented Feb 8, 2021

cc @astrojuanlu if you are able to test this branch, which also removes Node.js from the install.

@astrojuanlu
Copy link

On it!

@jtpio jtpio changed the title Upgrade to Jupyterlab 3.0 Upgrade to Jupyterlab 3.0 and Jupyter Resource Usage Feb 9, 2021
@jtpio
Copy link
Contributor Author

jtpio commented Feb 9, 2021

Pushed one more change to update from nbresuse to jupyter-resource-usage (which includes a prebuilt extension for JupyterLab 3.0).

@astrojuanlu
Copy link

Tested on an Ubuntu 20.04 virtual machine w/ Firefox, works like a charm 🚀

@jtpio
Copy link
Contributor Author

jtpio commented Feb 9, 2021

Nice, thanks for testing!

Need to check what's going on with the tests to make it ready for review soon.

@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/deploy-jupyterhub-3-in-tljh/7801/5

@yuvipanda
Copy link
Collaborator

Restarting the build fix the unit test, because we don't pin chardet properly. Thanks for getting this over the line, @jtpio :)

@yuvipanda yuvipanda merged commit 2c1f448 into jupyterhub:master Mar 21, 2021
@jtpio jtpio deleted the jupyterlab-3.0 branch March 22, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants