Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pull request GitHub template #302

Open
manics opened this issue Jun 12, 2020 · 3 comments
Open

Add a pull request GitHub template #302

manics opened this issue Jun 12, 2020 · 3 comments

Comments

@manics
Copy link
Member

manics commented Jun 12, 2020

Proposed change

Add a pull request template .github/pull_request_template.md

Alternative options

Do nothing

Who would use this feature?

Reviewers would have more information when reviewing PRs. For example, one thing I think is particularly useful is for PRs to have explicit testing instructions where appropriate, especially for large changes which require non-trivial configuration settings to test.

(Optional): Suggest a solution

I've made a start here:
https://github.com/manicstreetpreacher/test-bots/blob/master/.github/pull_request_template.md
This is inspired by https://github.com/stevemao/github-issue-templates/blob/master/conversational/PULL_REQUEST_TEMPLATE.md

See also the discussion in #288

@choldgraf
Copy link
Member

+1 from me, I think it'd be helpful

@sgibson91
Copy link
Member

I think this is a great idea! Can I suggest checking out the Turing Way PR template too? https://raw.githubusercontent.com/alan-turing-institute/the-turing-way/master/.github/PULL_REQUEST_TEMPLATE.md

@manics
Copy link
Member Author

manics commented Sep 24, 2020

Thanks all, I've finally opened a PR 😀 jupyterhub/.github#11
@trallard is helping too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants