PR template

[trallard]

Hey 👋🏼

Proposed change

With the recent merge of #654 and #655 I think we should also include templates for PR

Why?
Having standard templates will not only make it easier for those reviewing them to track the state of the PR but also will encourage the submitters to make sure they adhere to the contributing guidelines and make some checks before the PR is sent

Alternative options

--

Who would use this feature?

Contributors to the project

How much effort will adding it take?

Who can do this work?

Low effort - anyone could take this as this is a non-coding activity.
I can even take this as I already have some templates that I have for personal use/projects

[betatim]

Sounds like a good idea. Do you want to propose one? My only experience/recommendation is that we try and keep it short and not include things in a checklist that CI can/does check for us, let's bundle those as "make sure the checks all pass" if we feel that would help people. On a previous project we had a (at the end when we decided to remove it) checklist of seven or so items and most of the time people ignored the whole list :-/

[manics]

I opened a similar issue on team-compass for an org-wide template jupyterhub/team-compass#302
(and despite intending to work on it straight away I've failed to do so....)

[trallard]

This also slipped my to-do list. Want to work on this together @manics ?

[manics]

Definitely! How about if I open a PR on https://github.com/jupyterhub/.github/ based on the comments on jupyterhub/team-compass#302 and we go from there?